ensure executable paths are absolute #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemd requires absolute paths for executables. Relative path executables do not take $PATH env into account when resolving the executable.
manics
reviewed
Jun 7, 2023
consideRatio
reviewed
Jun 7, 2023
behrmann
reviewed
Jun 7, 2023
it's not strictly required, but it is required to get the right result
consideRatio
approved these changes
Jun 7, 2023
|
@consideRatio added one more push with clearer comments, so should be all set from me thanks everyone for the quick review! |
consideRatio
approved these changes
Jun 7, 2023
|
I'll create a changelog PR soon for 1.0.1, but I'd like to squeeze in some debugging log messages as well first. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd requires absolute paths for executables in order to resolve as expected.
Relative path executables do not take $PATH env into account when resolving the executable, only after launching the process, so
systemd-run bash -c exeworks, while justsystemd-run exewill not.The default executable for a Spawner is the relative
jupyterhub-singleuser, assuming $PATH will be resolved.Fixes the failure in jupyterhub/the-littlest-jupyterhub#915