-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Python 3.7+, fix test failures, test against Py 3.10 and 3.11, README/RELEASE update #19
Require Python 3.7+, fix test failures, test against Py 3.10 and 3.11, README/RELEASE update #19
Conversation
fb24b4b
to
6383c50
Compare
e5122fd
to
f1aa2a2
Compare
5d8ff67
to
fc4db44
Compare
@consideRatio do we use hatchling in other Jupyter projects already? Also I merged #18, but github doesn't seem to acknowledge that here in showiong me diffs :( |
fc4db44
to
cef351f
Compare
Rebased! Thanks @yuvipanda!!! I saw @minrk start to use it in https://github.com/minrk/jupyter-keepalive/blob/main/pyproject.toml so that is my inspiration towards this. |
I'm not sure, do you need that defined at all? Would it work to remove it entirely and have a pyproject.toml without hatchling defined as a build system? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@consideRatio so I'm totally lost on pyproject.toml in general, and haven't been keeping up :) My only requirement is that 'editable installs' (pip install -e .
) work. If it does for hatchling, happy to give it a shot here :) Do you know if it does? I can't seem to find info...
I'm quite lost as well, but I think this is fine! I'm happy to avoid having setup.py, setup.cfg, pyproject.toml all side by side. If adding hatchling to pyproject.toml makes us able to remove the setup.py thats nice. Regarding editable buildsI think can't use Python 3.5 and remove setup.py going for only pyproject.toml + a declared build-system, but you can if you have python 3.6+! So, this pattern is something we can adopt wider as well I think. Atm, you can use |
Thanks, @consideRatio! If |
Wiee thanks for your quick review of this @yuvipanda, greatly appreciated!!! ❤️ 🎉 |
I've been exploring hatchling, which is kinda the PyPA successor to flit, but with hooks for optional build steps. It's being adopted in the JupyterLab/jupyter-releaser projects, so there's a plugin to build jupyterlab extensions, so we don't have to cargo-cult our npm build steps around everywhere in setup.py. That's why I picked it for jupyter-keepalive. I probably would have stuck with setuptools in keepalive were it not for the lab extension. If you have a simple Python-only package like this one, there isn't really a difference between using setuptools and hatchling with pyproject.toml. You don't need setup.py with either one, but if you have setup.py with setuptools, it's the two-line
As I understand hatchling more, I think we can make the jupyterhub build/install much simpler than the complicated steps we have now. |
Based on #18 to avoid merge conflicts. Excluding that #18, this PR involves a flurry of minor fixes.
__version__
Closes Provide a non-technical introduction paragraph in the readme #15
Closes Fix CI test failures #12
Properly closes Fix CI test failures #12
DRAFT
Currently working to fix test failing intermittently