Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor typos #456

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Minor typos #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,5 @@ test_file_text.txt
# Untracked artifacts from the conda script
repo2docker/buildpacks/conda/environment.py-3.5.yml
repo2docker/buildpacks/conda/environment.py-3.6.yml

\.vscode/
nuest marked this conversation as resolved.
Show resolved Hide resolved
6 changes: 3 additions & 3 deletions repo2docker/buildpacks/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ def get_post_build_scripts(self):
An ordered list of executable scripts to execute after build.

Is run as a non-root user, and must be executable. Used for performing
build time steps that can not be perfomed with standard tools.
build time steps that can not be performed with standard tools.

The scripts should be as deterministic as possible - running it twice
should not produce different results!
Expand All @@ -341,12 +341,12 @@ def get_post_build_scripts(self):

def get_start_script(self):
"""
The path to a script to be executated at container start up.
The path to a script to be executed at container start up.

This script is added as the `ENTRYPOINT` to the container.

It is run as a non-root user, and must be executable. Used for performing
run time steps that can not be perfomed with standard tools. For example
run time steps that can not be performed with standard tools. For example
setting environment variables for your repository.

The script should be as deterministic as possible - running it twice
Expand Down