Default allow_privilege_escalation to False #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows it to be set to None as well, to not set the property. This is a breaking change for hubs where admins were granting sudo rights to users. That already required some extra work, so this would be an additional propety to set for that. The added security benefit from this much more secure default is well worth the breakage IMO. Fixes jupyterhub#544
consideRatio
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
This LGTM, thanks @yuvipanda for getting this done!!! ❤️ 🎉
It would be good to have another reviewer agree we get this right as its a breaking change. @minrk @manics, perhaps you could have a look?
Note that this is both a bugfix, and a change of default.
- Bugfix: because our "True" value in the past acted as "None" rather than an explicit True.
- A change of default: because now we instead of having "None" as a default, we have "False" as an explicit default.
|
Makes sense! |
|
Ty, @minrk and @consideRatio |
yuvipanda
added a commit
to jupyterhub/systemdspawner
that referenced
this pull request
Jan 26, 2022
Protects against vulnerabilities such as https://arstechnica.com/information-technology/2022/01/a-bug-lurking-for-12-years-gives-attackers-root-on-every-major-linux-distro/ or the previous sudo vulnerability. Equivalent of jupyterhub/kubespawner#545 This should be counted as a braking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows it to be set to None as well, to not set the property.
This is a breaking change for hubs where admins were granting
sudo rights to users. That already required some extra work,
so this would be an additional propety to set for that. The
added security benefit from this much more secure default is
well worth the breakage IMO.
Fixes #544