Allow easily augmenting the pod config before launching #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easy for people to configure this without having to inherit from KubeSpawner and change it.
|
/cc @foxish for easier augmenting of pod specification. |
foxish
reviewed
Dec 8, 2017
kubespawner/spawner.py
Outdated
|
|
||
| This can be a coroutine if necessary. When set to none, no augmenting is done. | ||
|
|
||
| This is very useful if you want to modify the pod being launched programattically. |
There was a problem hiding this comment.
nit: typo in "programattically"
kubespawner/spawner.py
Outdated
| @@ -909,6 +931,8 @@ def start(self): | |||
| # FIXME: Have better / cleaner retry logic! | |||
| retry_times = 4 | |||
| pod = yield self.get_pod_manifest() | |||
| if self.augment_pod: | |||
| pod = self.augment_pod(self, pod) | |||
There was a problem hiding this comment.
So the augmenter can access other traitlets, and also call methods to get things like auth_state...
|
This is a good step towards more flexible parameterizing in the spawner. Thanks @yuvipanda |
It doesn't actually seem to exist in traitlets for some reason
|
np @foxish! Glad to help :) |
|
/cc @minrk too. I welcome some amount of bikeshedding on the name of this thing. |
There is some convention around calling configurable callables |
minrk
approved these changes
Dec 8, 2017
|
@minrk renamed! |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easy for people to configure this without
having to inherit from KubeSpawner and change it.