Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument JupyterHub to record events with jupyter_telemetry [Part II] #2698
Instrument JupyterHub to record events with jupyter_telemetry [Part II] #2698
Changes from 15 commits
41b2e6e
1e578a2
eca4f33
5aaa526
1225ff4
dcde402
aea2eef
2b1bfa0
c34bcab
439e438
263c5e8
c9d52be
7fd3271
949d8d0
ac32ae4
898fea9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allowed_schemas
Is it possible to easily generate a list of all current schemas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm... we don't have functionality for this in telemetry, but that's an interesting idea. We could add an option to get all registered schemas in jupyterhub.
Our general approach has been to force admins to whitelist all events they'd like to record, so that there's no data collected without operator knowledge.
@yuvipanda, thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can files like this be generated instead of manually maintained? Not needed immediately, but for future ideas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not right now. That was actually my intention for adding pydantic to telemetry. Check out my example PR on Yuvi's JupyterHub branch..
With pydantic, we get doc generation, validation, and testing for free. The events themselves are python objects.