-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extension for Jupyter Notebook 7 #425
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good from the technical perspective, but I'm not confident at all on the extension code =/
There is some documentation that is worth updating as part of this I think. We have a "labextesion" folder, but its now an extension for JupyterLab 3-4, and an extension for Notebook 7? I didn't know about it, but there was some behavior in notebook 6 also?
As you probably overview the typescript code base quite well at this point, could you provide some code contributor / maintainer facing docs overviewing what the various code files does?
EDIT: removed resolved comment.
This reverts commit f503dde.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working this @bollwyvl!!! ❤️ 🎉 🌻
I've struggled a bit since this is not a domain I have much experience in, but I have some suggestions related to docs to a large extent.
- Resolve comment about
NOTEBOOK_VERSION
- Revise README.md's heading
### JupyterLab extension
- Revise labextension/README.md
- Is this a Notebook 7 + JupyterLab extension now?
- Is it a Notebook 6 extension somehow also? I was surprised about the notebook 7 functionality added already was found in notebook 6.
- (optional) Add top-level comments for .ts files providing a high level overview in a paragraph or two
- Something like this will help me greatly as a novice about code for frontend extensions in reviewing or possibly fixing a bug etc.
I've observed a few address already in use failures, I'm not sure if they have started showing up more and more with this PR or not, but they are quite frequent now. I've seen them about ~50% of the times the tests run. Could it be related to making fixtures session based? |
This populates the entry on
Yes, that's the point of this PR. Notebook 7 is built of 95% jupyterlab components, so mostly everything works the same, but you have to watch out for
Yes, the existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, and with the amazing work with browser tests I think we can go for a merge even though I'm not so confident reviewing the frontend code. What do you think @bollwyvl?
This one's tricky. Getting rid of the hard-coded port (e.g. |
Sure, why not. Could do an |
I opened #426 about the intermittent test failrues, lets go for it! |
References
Changes
ILauncher
tokens.ts
prettier
install to account for CI updatestypescript
session
scoped server fixturepytest
suite in single stepScreens
Breaking Changes