maint: add pre-commit config #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
Thanks for working on this! We should make sure that the tigervnc package that we vendor does not formatting applied to it, as that would make re-vendoring it difficult. The 'right' thing to do is to spin it out into its own package, but I don't know if any of us have the bandwidth for that right now. |
consideRatio
commented
Jan 14, 2023
|
|
consideRatio
force-pushed
the
pr/add-pre-commit
branch
from
b1af2e9 to
9e3daca
Compare
for more information, see https://pre-commit.ci
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've now activated pre-commit.ci at https://github.com/organizations/jupyterhub/settings/installations/17782968.