duplicate NotebookApp CLI args to ServerApp

ahead of ServerApp deprecating handling of NotebookApp aliases
jupyterhub · Feb 15, 2023 · 2f7189e · 2f7189e
1 parent 68e093f
commit 2f7189e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/binderhub/binderspawner_mixin.py b/binderhub/binderspawner_mixin.py
@@ -84,6 +84,10 @@ def get_args(self):
             if self.cors_allow_origin == "*":
                 args.append("--NotebookApp.allow_origin_pat=.*")
             args += self.args
+            # ServerApp compatibility: duplicate NotebookApp args
+            for arg in list(args):
+                if arg.startswith("--NotebookApp."):
+                    args.append(arg.replace("--NotebookApp.", "--ServerApp."))
         return args
 
     def start(self):

diff --git a/helm-chart/binderhub/values.yaml b/helm-chart/binderhub/values.yaml
@@ -169,6 +169,10 @@ jupyterhub:
                     if self.cors_allow_origin == "*":
                         args.append("--NotebookApp.allow_origin_pat=.*")
                     args += self.args
+                    # ServerApp compatibility: duplicate NotebookApp args
+                    for arg in list(args):
+                        if arg.startswith("--NotebookApp."):
+                            args.append(arg.replace("--NotebookApp.", "--ServerApp."))
                 return args
 
             def start(self):