Replace @jupyterlab/rjsf with FormComponent from @jupyterlab/ui-components #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
reviewed
Dec 2, 2024
Meriem-BenIsmail
force-pushed
the
form-component-rjsf
branch
2 times, most recently
from
363b241 to
6d6ee87
Compare
|
Integration tests report: appsharing.space |
|
Preview PR at appsharing.space |
|
The Union operator form does not show dropdown selectors anymore: Before this PR:Screencast.From.2024-12-03.11-03-10.mp4With this PR:Screencast.From.2024-12-03.11-05-57.mp4 |
Meriem-BenIsmail
force-pushed
the
form-component-rjsf
branch
3 times, most recently
from
1e463ed to
9d3e2bb
Compare
|
please update snapshots |
|
Triggered CI |
Meriem-BenIsmail
force-pushed
the
form-component-rjsf
branch
from
4a24976 to
43f0ebe
Compare
martinRenou
reviewed
Dec 3, 2024
There was a problem hiding this comment.
Great work on this!
I'll just leave a couple of comments here for now before taking a deep dive in the code.
I see some validation errors when making two Unions one after the other, I wonder if it has to do with the new validation logic?:
Screencast.From.2024-12-03.16-57-53.mp4
martinRenou
reviewed
Dec 4, 2024
Meriem-BenIsmail
force-pushed
the
form-component-rjsf
branch
from
43f0ebe to
1416d92
Compare
|
please update snapshots |
Meriem-BenIsmail
force-pushed
the
form-component-rjsf
branch
3 times, most recently
from
1119b49 to
64be615
Compare
|
please update snapshots |
Meriem-BenIsmail
force-pushed
the
form-component-rjsf
branch
from
e4d4b42 to
26dad41
Compare
for more information, see https://pre-commit.ci
|
please update snapshots |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the JupyterCAD to use the FormComponent from the
@jupyterlab/ui-componentspackage instead of SchemaForm.Key Changes:
@jupyterlab/rjsfwith FormComponent, the standardized form component in the JupyterLab ecosystem.FormComponentto ensure schema validation.CustomArrayFieldWithoutButtons) to maintain existing customization for array data entry.