Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable transform control for readonly files #594

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Disable transform control for readonly files #594

merged 1 commit into from
Nov 28, 2024

Conversation

martinRenou
Copy link
Member

Fix #592

@martinRenou martinRenou added the enhancement New Feature or improvement label Nov 28, 2024
arjxn-py
arjxn-py approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@martinRenou martinRenou merged commit 72ab378 into jupytercad:main Nov 28, 2024
10 of 11 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Preview PR at appsharing.space

@github-actions GitHub Actions
Copy link
Contributor

Integration tests report: appsharing.space

@martinRenou martinRenou deleted the transform_readonly branch November 28, 2024 13:36
@SylvainCorlay
Copy link
Member

If we make these things command-based, we should eventually make the comment available or unavailable depending on the context.

@martinRenou
Copy link
Member Author

Opening an issue now about adding commands to the command palette!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjxn-py arjxn-py arjxn-py approved these changes

Assignees
No one assigned
Labels
enhancement New Feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should the transform controls be disabled for STEP/STL files like other buttons changing the model
3 participants
@martinRenou @SylvainCorlay @arjxn-py