Object properties panel: Use selected object name as the title #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview PR at appsharing.space |
|
Integration tests repot: appsharing.space |
|
This is looking great. |
|
Completely empty, as in removing the "object properties" title?
|
|
Yes, or even like in the standard panel. 
|
|
The current behavior is that you can still edit the properties of the last thing that was selected, which may be misleading. |
|
Clicking on other documents removes the form but still keeps the object name.
|
|
I think it is a clear improvement over the current state. I would be super keen on integrating it as it stands. |
|
I marked the PR as ready to review again. Although trung's comment may be an actual bug of my implementation |
|
Bot please update snapshots! |
for more information, see https://pre-commit.ci
trungleduc
force-pushed
the
update_object_properties_title
branch
from
53cb67c to
3969682
Compare
trungleduc
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #477
Closes #543
Screencast.from.2024-10-25.15-34-35.mp4
cad223.mp4