Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OCC build #221

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Update OCC build #221

merged 3 commits into from
Nov 17, 2023

Conversation

martinRenou
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupytercad/update_occ

@martinRenou martinRenou force-pushed the update_occ branch 2 times, most recently from 35f3a73 to 80ce29f Compare November 15, 2023 13:57
@martinRenou
Copy link
Member Author

martinRenou commented Nov 15, 2023 •
edited
Loading

Remaining TODO:

  • Fix CI (pydantic issue?) Done in Pin pydantic (again) #222 ✅
  • Get rid of manual lib/index.js and lib/index.d.ts ✅
  • Get rid of the full WASM build file from dist ✅

@martinRenou martinRenou force-pushed the update_occ branch 2 times, most recently from 34619c9 to 7b7087e Compare November 16, 2023 15:51
@martinRenou martinRenou marked this pull request as ready for review November 16, 2023 16:19
@martinRenou
Copy link
Member Author

@trungleduc marking as ready for review! But as discussed, let's merge after your refactor PR

@trungleduc
Copy link
Member

Thanks @martinRenou!

@martinRenou
Copy link
Member Author

Doesn't build anymore since the rebase
I need to push a commit

@martinRenou
Copy link
Member Author

Back to the check-release and integration tests failures, let's merge

@martinRenou martinRenou merged commit 5d43cc6 into jupytercad:main Nov 17, 2023
3 of 6 checks passed
@martinRenou martinRenou deleted the update_occ branch November 17, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @trungleduc