-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle buttons for clipplane and wireframe do not toggle in JupyterLite #488
Comments
This was implemented in #441 and it looks like it's not working anymore? |
I wonder if the switch to reactive toolbar may broke it #455 |
Maybe @brichet would know if the reactive toolbar does not support toggled buttons. |
Hi there, I tried reproducing this on my end and It works fine for me (I'm at the latest commit) Maybe can you try reproducing? toggle.movEDIT: Yes, I just realised and checked that it's not working on jupyterlite deployment |
AFAIK the reactive toolbar handles the buttons in the same way as the regular toolbar, storing only those that overflow into a popup toolbar. |
Indeed. Although I can see the class change on the button. |
So this may be JupyterLite not bringing the Lumino CSS for |
Ping @jtpio |
hmm strange that JupyterLite would not include this rule, since it should include the Lumino CSS by default. Are you able to check the rule is available when using regular JupyterLab, and not with JupyterLite? (for example via the elements tab of the dev tools) |
I mean can you point at the specific CSS rule? (so it's easier to check why it would be missing in lite) |
It should be toggle.mov |
For the class yes. But what is the expected CSS rule? |
This is the only rule we could find in lumino - |
So to echo the question above:
Is this rule on the page for JupyterLab, and not for JupyterLite? |
I cannot see this exact rule but there are significant differences between how lab is rendering the button and how lite is. One of the major one is that in jupyterlab button is JupyterLab Screen.Recording.2024-10-17.at.14.52.04-1.movJupyterLite Screen.Recording.2024-10-17.at.14.56.15-1.mov |
Even by searching for |
Can't find one in local jupyterlab: con.mov |
Indeed. It looks related to the changes in JupyterLab w.r.t the toolbar buttons. Maybe there is a |
Will the "bug" be resolved in a future version of JupyterLite ? The CSS change could be submitted upstream in Lab. |
From a conversation with @martinRenou on video, Yes
Sounds good, happy to do that if I'm good to do that, please let know if someone else shall do it. |
We could decide to make the clipping toolbar icon should appear as toggled when clipping is enabled.
The text was updated successfully, but these errors were encountered: