Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add js files in package manifest #87

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Add js files in package manifest #87

merged 1 commit into from
Jan 4, 2021

Conversation

MircoT
Copy link
Contributor

@MircoT MircoT commented Dec 28, 2020

#83 problem could be solved adding the js files through the manifest. The sdist package contains all the files needed after this commit.

blink1073
blink1073 approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit f948b2e into jupyter:master Jan 4, 2021
@blink1073
Copy link
Contributor

Confirmed that https://pypi.org/project/terminado/0.9.2/ has the files.

@blink1073 blink1073 mentioned this pull request Jan 4, 2021
Closed
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MircoT @blink1073