Make sure that all process output makes it to the terminal #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate process-start race
|
I don't understand the failure in AppVeyor--looks like it succeeded but very slowly? |
|
Merging and fixing in another PR. In the future, if you use a branch other than master for your branch, we'd be able to push fixes directly to this. |
|
Will do. I developed it on a ticket branch of mine and then PRed to master in my fork; I can just not do that second thing in the future. Thanks for the quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The important change is that the terminal would often not print output prior to the first prompt. This was some combination of the spawned shell process producing output before the PtyWithClients object was there to catch it, and the PtyWithClients object not registered any clients yet. This PR fixes both of those and addresses jupyterlab/jupyterlab#9023
There are two other classes of changes in here, which are flake8, because I have my editor set up to flake8ify on save. Those two are replacing the lambdas with inline functions, and the whitespace changes. If you care, I can go through and reverse those.