-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix traitlets typing #7082
Fix traitlets typing #7082
Conversation
|
||
from ._version import __version__ | ||
|
||
HERE = os.path.dirname(__file__) | ||
|
||
Flags = t.Dict[t.Union[str, t.Tuple[str, ...]], t.Tuple[t.Union[t.Dict[str, t.Any], Config], str]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @blink1073
Wondering if there would be a better / simpler way to handle this in downstream apps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm working on making them just dict[str, Any]
in Application
and JupyterApp
, rather than trying to be more specific. https://github.com/ipython/traitlets/pull/873/files#diff-5453d413070d06bcf7ba7f017b9cf364e774627fad69964a6471449e5c16dc37R371
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #7081