fix trusted status indication #7036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
for more information, see https://pre-commit.ci
krassowski
reviewed
Sep 7, 2023
There was a problem hiding this comment.
Thanks @adigaboy. I left some minor comments on code style :)
|
bot please update playwright snapshots |
|
Thanks! The remaining test failure is not related and is being addressed in #7037. |
|
My pleasure! Will look for other issues to fix also :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed trusted check to be similar to:
https://github.com/jupyterlab/jupyterlab/blob/19fa54fcbf3e684d7c4466807af549ba0d565ad2/packages/notebook/src/truststatus.tsx#L240-L259
includes check cell type if code
some total code cells
check and sum trusted cells