Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve about dialog #6996

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Improve about dialog #6996

merged 2 commits into from
Aug 3, 2023

Conversation

yjrab
Copy link
Contributor

@yjrab yjrab commented Aug 1, 2023

Suggestions for Improving about dialog UI

This is to make Jupyter Notebook's about dialog UI similar to that of Jupyter Lab's.
This is related to issue: Improve the About dialog #6552

Modifications in base.css for .jp-AboutNotebook-version

To make sure that the spacing between the version line and external link is bigger than before and closer to how it is in Jupyter Lab. More importantly, to make sure that the default dialog box when first opened has the same height and width as the dialog box in Jupyter Lab.

- padding: var(--jp-flat-button-padding);
+ padding-bottom: 30px;

Modifications in base.css for .jp-AboutNotebook-about-externalLinks

To make sure that the spacing around the external links are consistent with how it is in Jupyter Lab.

- padding-top: 12px;

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Binder 👈 Launch a Binder on branch yjrab/jupyter-notebook/improve-about-dialog

@yjrab
Copy link
Contributor Author

yjrab commented Aug 1, 2023

More Suggestions for Improving about dialog UI

I have other modifications to show to improve the about dialog.
Do I perform another seperate pull request?
Thank you.

@jtpio jtpio added this to the 7.0.x milestone Aug 2, 2023
@jtpio
Copy link
Member

jtpio commented Aug 2, 2023

Thanks @yjrab!

Would it be possible to provide a before / after screenshot of the changes so it's easier to have an idea of the visual changes?

@yjrab
Copy link
Contributor Author

yjrab commented Aug 2, 2023

Hi @jtpio, yes absolutely!

The following image is the Jupyter Notebook About Dialog Before:
Jupyter Notebook About Dialog Before

The following image is the Jupyter Notebook About Dialog After:
Jupyter Notebook About Dialog After

The following image is the Jupyter Lab About Dialog used as reference:
Jupyter Lab About Dialog

@jtpio jtpio linked an issue Aug 3, 2023 that may be closed by this pull request
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 262781e into jupyter:main Aug 3, 2023
24 of 26 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the About dialog
2 participants