Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show file checkboxes by default in the file browser #6377

Merged
merged 3 commits into from
Apr 26, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 26, 2022

Enable the file checkboxes features in the file browser added in JupyterLab in jupyterlab/jupyterlab#12299.

file-checkboxes.mp4

TODO

  • Enable the setting by default if there is no user override
  • Update reference snapshots
  • Check if we can open multiple files (or track that in a different issue)

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/checkboxes

@jtpio
Copy link
Member Author

jtpio commented Apr 26, 2022

cc @gabalafou FYI this is what it looks like in Notebook v7

@jtpio jtpio added this to the 7.0 milestone Apr 26, 2022
@jtpio
Copy link
Member Author

jtpio commented Apr 26, 2022

Check if we can open multiple files (or track that in a different issue)

This seems to be the case:

checkboxes-open-multiple.mp4

@jtpio jtpio marked this pull request as ready for review April 26, 2022 16:11
@jtpio
Copy link
Member Author

jtpio commented Apr 26, 2022

A nice follow-up would be to implement something similar to the classic notebook, with action buttons showing up in the file browser toolbar:

checkboxes-buttons.mp4

These actions are already accessible via the context menu, but could still be nice to have in the toolbar so they are more visible.

@gabalafou would you be interested in looking into it?

I'll open a separate issue so we can more easily track this. Maybe this would need some other changes in JupyterLab, not sure there is a signal or a way to know when a selection has changed already.

Thanks!

@jtpio jtpio merged commit 722f1d7 into jupyter:main Apr 26, 2022
@jtpio jtpio deleted the checkboxes branch April 26, 2022 16:47
@jtpio
Copy link
Member Author

jtpio commented Apr 26, 2022

I'll open a separate issue so we can more easily track this.

Tracked in #6378

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant