Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover from failure to render mimetype #6181

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Sep 15, 2021

It's easier to review the diff while disabling whitespace diffs: https://github.com/jupyter/notebook/pull/6181/files?diff=split&w=1

This is closer to JupyterLab's behavior.

As an example, if a Jupyter widget fails to render (due to widget state not found), we display other available mimetypes instead of nothing.

This goes in the direction of this PR: matplotlib/ipympl#343 (add support for saving a static version of the matplotlib plot next to the widget mimetype) which works properly in JupyterLab but not in Notebook yet.

PR goes in pair with jupyter-widgets/ipywidgets#3280

@SylvainCorlay
Copy link
Member

This looks good to me!

@martinRenou martinRenou force-pushed the recover_from_failure_to_render_mimetype branch from cce6674 to 49d1ad9 Compare September 16, 2021 13:17
@SylvainCorlay SylvainCorlay merged commit 41f1483 into jupyter:master Sep 18, 2021
@martinRenou martinRenou deleted the recover_from_failure_to_render_mimetype branch September 20, 2021 06:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants