Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow jupyter_server-based contents managers in notebook #5957

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Allow jupyter_server-based contents managers in notebook #5957

merged 2 commits into from
Feb 2, 2021

Conversation

afshin
Copy link
Member

@afshin afshin commented Jan 21, 2021

notebook's contents_manager_class trait doesn't accept subclasses of jupyter_server's ContentsManager. This is a problem for anyone looking to write custom, forward-looking contents managers. We should relax this constraint here (albeit, raise a warning).

This PR relaxes the contents_manager_class to allow these managers. To do this, new traittypes are defined and used that check the incoming types/instances against a list of classes.

Co-authored-by: Kevin Bates <kbates4@gmail.com>
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kevin-bates kevin-bates merged commit 8cd9a5f into jupyter:master Feb 2, 2021
@blink1073 blink1073 added this to the 6.3 milestone Mar 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants