Require a file name in the "Save As" dialog #5733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5732 by checking for empty file names in the "Save As" dialog and refusing to save the file. It also helpfully highlights the instructions to the user in red.
It would be better if the error message were clearer, or even better if the save button were disabled until a file name was entered, but that would require a much larger and more complex change to the code. (Maintainers, feel free to take this patch and run with it!)