[WIP] Make the last modified date consider files in subdirectory #5336
Conversation
|
hi @mikebeijen - this is still marked as WIP. This seems like a useful fix, do you know about how much is left to do? |
|
Hi @mikebeijen - it would be great to get this into NB 6.1 - for which momentum is mounting. Any chance you could get this out of WIP soon? |
| console.log(len) | ||
| console.log(list) | ||
| console.log("********************************************************") |
| console.log("LIST CONTENTS BELOW") | ||
| console.log(this.contents.list_contents(that.notebook_path)) |
|
It looks like this is still a ways from being ready. @mikebeijen, feel free to ping me when you're ready for review. |
|
It certainly is not ready yet. Likely, I will not have the time to work on it the upcoming time. So let's not count on this one. Will consider picking up the issue later. |
|
Thanks, @mikebeijen. Feel free to ping me when you pick this back up. Notebook is likely going to freeze on features in the near future. I'll do my best to communicate here if that happens before you can work on this again. |
|
Just checked with Notebook 7 / JupyterLab and they seem to be considering files in subdirectories correctly: subdirectory-file-changed.mp4Closing as fixed, and also because the classic notebook UI has now moved to https://github.com/jupyter/nbclassic. If you think this would still be relevant to be available in the classic notebook UI provided by |
Fixes #5300
This PR makes last modified date consider the last modified date files in its subdirectory.
Currently WIP, needs sorting of timestamps and testing.