Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flush iopub before sending restarting/dead status messages #3759

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

minrk
Copy link
Member

@minrk minrk commented Jul 13, 2018

to ensure (approximately) that all messages from the stopped kernel are delivered before the dead/restarting message

Since this event is triggered after a process has stopped, the only race is with messages waiting in zmq to be handled, so flushing the zmq stream should eliminate the race in all but the most pathological cases.

cc @jasongrout

@takluyver
Copy link
Member

Test failures in js/services look consistent enough to be something real.

@takluyver takluyver added this to the 5.7 milestone Jul 14, 2018
@minrk
Copy link
Member Author

minrk commented Jul 18, 2018

Yup, I think I mixed something up. Will fix.

@minrk minrk changed the title flush iopub before sending restarting/dead status messages [wip] flush iopub before sending restarting/dead status messages Jul 18, 2018
to ensure (approximately) that all messages from the stopped kernel are delivered before the dead/restarting message
@blink1073
Copy link
Contributor

Still wip?

@minrk minrk changed the title [wip] flush iopub before sending restarting/dead status messages flush iopub before sending restarting/dead status messages Jul 30, 2018
@minrk
Copy link
Member Author

minrk commented Jul 30, 2018

Should be fixed now

@blink1073
Copy link
Contributor

Thanks!

@blink1073 blink1073 merged commit 34baae5 into jupyter:master Aug 13, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants