ConfigManager should not write out default values found in the .d directory #3485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup of #3116.
When the config manager reads the
.json
+.d/*.json
files, all the data gets merged into one dict. When writted out again, everything ends on in the root.json
file. Here I remove all entries that are already present in the.d/*.json
files.For instance, when installing ipyvolume, you end up with the file
{prefix}/etc/jupyter/nbconfig/notebook.d/ipyvolume.json
. If you now runjupyter nbextension ...
for anything, all the data from theipyvolume.json
file ends up in{prefix}/etc/jupyter/nbconfig/notebook.d
. Uninstalling ipyvolume will never clean this up, so it will always stay around. This is now avoided by this PR.