[WIP] no longer persist output scroll, collapse state in metadata

[minrk]

make these purely runtime state

Marked WIP pending discussion /cc @ellisonbg @fperez

[ellisonbg]

Looks like we didn't quite finish the discussion at the meeting. I will follow up with Mike and Kyle and post back here.

…

On Thu, Jun 1, 2017 at 6:27 PM, Min RK ***@***.***> wrote: make these purely runtime state Marked WIP pending discussion /cc @ellisonbg <https://github.com/ellisonbg> @fperez <https://github.com/fperez> ------------------------------ You can view, comment on, or merge this pull request online at: #2543 Commit Summary - no longer persist output scroll, collapse state in metadata File Changes - *M* notebook/static/notebook/js/codecell.js <https://github.com/jupyter/notebook/pull/2543/files#diff-0> (9) Patch Links: - https://github.com/jupyter/notebook/pull/2543.patch - https://github.com/jupyter/notebook/pull/2543.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2543>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABr0OtNZu5unSLakapkyffVsXY0LHvSks5r_2T8gaJpZM4Ntuip> .

-- Brian E. Granger Associate Professor of Physics and Data Science Cal Poly State University, San Luis Obispo @ellisonbg on Twitter and GitHub bgranger@calpoly.edu and ellisonbg@gmail.com

[takluyver]

What happened with that discussion?

[ellisonbg]

The PR that @rgbkrk opened is here:

jupyter/nbformat#94

That PR doesn't change the existing "collapsed" or "scrolled" metadata, but does add two new metadata fields. We are still finalizing that PR. Once that is done, we would follow up with a separate nbformat PR to deal with the "collapsed" or "scrolled" metadata.

[rgbkrk]

Certainly a cleanup from before.

[takluyver]

Are we still aiming to get this into notebook 5.1, or does it depend on PRs in other repos?

[gnestor]

@minrk I'm pushing to release notebook 5.1 this week, so last chance to squeeze this in!! Let me know if I can help...

[tritemio]

It would be nice to have this in the next release. This metadata saved in the notebook is causing quite a bit of annoying overhead to me.

[minrk]

@tritemio I think the most annoying part of this is fixed by #1865, which fixed a bug where we were writing even the default values of this metadata. That shouldn't be happening anymore, so if you aren't manually collapsing and scrolling cells, then this PR shouldn't change anything from 5.0.

I do think this is largely unrelated to the discussion on nbformat. This PR is a question of whether we should be persisting this UI state, which is not the same as what's discussed in the schema PR. i.e. are these flags ephemeral UI state or are they persistent properties of the notebook.

All of the discussion around persistent properties of notebooks involve proposing entirely new keys with new meanings that aren't these two, so any changes here are not really related to those under discussion elsewhere.

[tritemio]

@minrk thanks for the clarification, so maybe this is the wrong issue but I still get the collapsed metadata every time I execute the notebook through nbconvert. Luckly I found that I can easily get rid of it through nbstripout.