Patch CodeMirror 5.22 #2066
Merged
Patch CodeMirror 5.22 #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@minrk I've submitted #2068 to merge into this branch.We shoud have a fix on CodeMirror's end eventually (see codemirror/codemirror5#4454), but this will allow us to ship 4.3.2. |
|
Maybe it would be better to patch in-place after |
|
Let's include this in 4.3.2 👍 |
gnestor
approved these changes
Jan 25, 2017
|
@meeseeksdev backport to 4.x |
Ok, I think I see the bug ... |
|
Oops, something went wrong applying the patch... Please have a look at my logs. |
Carreau
pushed a commit
to Carreau/jupyter_notebook
that referenced
this pull request
Jan 31, 2017
Merge pull request jupyter#2066 from jupyter/cm-up Patch CodeMirror 5.22
Carreau
pushed a commit
to Carreau/jupyter_notebook
that referenced
this pull request
Jan 31, 2017
Merge pull request jupyter#2066 from jupyter/cm-up Patch CodeMirror 5.22
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2037
TODO:
@gnestor this PR is from a branch on trunk, so feel free to play around with fixes for the cursor issue in this PR
I can't work on a fix because I can't reproduce #1967 (Safari 10.0.3 or 10.2 preview)
Assuming the fix is simple, we might consider a patch-level backport to 4.3.2 as well.