-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugs involving merging of cells #665
Comments
I agree that delete should act on selected cell, not marked. We should have a separate delete marked. |
I am not sure about that. I don't see why delete is different from other On Mon, Oct 26, 2015 at 2:40 PM, Matthias Bussonnier <
Brian E. Granger |
Because in 4.0 |
And/Or, we should alway have selected cell being considered as marked. |
Yeah, I think the behavior should be the same ( |
Seeing the issues with marked cell, I'm wondering if we should'nt have disabled/revert ed it for 4.1. The contiguous selection was more than enough, and we push it too far. It's a feature that will only be used efficiently only by 1% of the 1% of users using it. |
The introduction of marked cells was not to address discontinguous We should just take our time and get the design right before shipping. But Overall the cell marking is working extremely well - with only a few edge Can you clarify what the problem is? On Mon, Oct 26, 2015 at 2:51 PM, Matthias Bussonnier <
Brian E. Granger |
I completely disagree with that point. The marked cell introduce a completely new layer of abstraction that distinguish marked vs selected. marked and selected where the same set of cells, and action where applied to this unique set. The 2 sets are disjoined and it is completely unclear to which of this 2 sets of cells each action applies. Worse, the set to which these actions apply is state dependent. If now I have to explain to someone what delete does, my answer need to start with: "It depends". Even worse if I look at a notebook I cannot tell what it will do. Both are on current master. |
Addendum: this show that the problem is not only on merge.
|
The UI involving the merging of cells is broken. There are a few related issues:
First, you can choose to "undo delete cell", but it doesn't remove the source from the first cell that was merged in. That's annoying, but not super problematic if we decide we don't want to deal with that (I think it was handled properly before? I could be misremembering, though).
Next, the resulting merged cell is still marked. I think it should be unmarked after the merge operation is complete.
Finally, there's also a more serious issue. Steps to reproduce:
The text was updated successfully, but these errors were encountered: