-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Show Header command to the command palette #6401
Comments
Hello, I found this issue on https://ovio.org/projects and would love to contribute! I am new to helping Github open source but have few years of coding experience. Please let me know! |
Thanks @jeewonkoo! The first step would be to fork the repository and follow the contributing guide to get the local environment up and running: https://github.com/jupyter/notebook/blob/main/CONTRIBUTING.md. Up to being able to open the application with And then follow the similar code as hinted in the top comment: #6401 (comment) But located in this plugin: notebook/packages/application-extension/src/index.ts Lines 478 to 545 in ec4ce20
That would mean adding
And then the code to add the command to the palette: if (palette) {
palette.addItem({ command: CommandIDs.toggleTop });
} Don't hesitate to open a pull request early, even if it's not finished or ready yet. Thanks! |
Sounds good! I will work on it. |
Fixed by #6415, thanks @jeewonkoo! |
Problem
The Show Header command is available as a menu item:
show-header-command.mp4
However it is not available in the command palette.
Proposed Solution
The plugin adding the command is defined here:
notebook/packages/application-extension/src/index.ts
Lines 424 to 463 in 9e81700
We'll need to add the optional
ICommandPalette
to add the command to the palette if available.As an example implementation, the command to toggle zen mode is added to the palette here:
notebook/packages/application-extension/src/index.ts
Lines 526 to 528 in 9e81700
The text was updated successfully, but these errors were encountered: