Merge pull request #2739 from takluyver/editor-cm-mode-mime

Set CodeMirror mode using mimetype, not mode name
jupyter · Aug 8, 2017 · f8d4d6a · f8d4d6a
2 parents b099303 + 835bbd1
commit f8d4d6a
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/notebook/static/edit/js/editor.js b/notebook/static/edit/js/editor.js
@@ -150,8 +150,10 @@ function(
         /** set the codemirror mode from a modeinfo struct */
         var that = this;
         utils.requireCodeMirrorMode(modeinfo, function () {
-            that.codemirror.setOption('mode', modeinfo.mode);
+            that.codemirror.setOption('mode', modeinfo.mime);
             that.events.trigger("mode_changed.Editor", modeinfo);
+        }, function(err) {
+            console.log('Error getting CodeMirror mode: ' + err);
         });
     };