Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for notebook 5.0 markdown cell attachments #692

Closed
parente opened this issue Apr 24, 2017 · 6 comments · Fixed by #805
Closed

Support for notebook 5.0 markdown cell attachments #692

parente opened this issue Apr 24, 2017 · 6 comments · Fixed by #805
Labels
tag:Upstream Related to an upstream project (e.g., mistune, nbconvert) or notebook example type:Enhancement A proposed extension to the behavior of the project

Comments

@parente
Copy link
Member

parente commented Apr 24, 2017

Notebook 5 supports attachments in markdown cells. nbviewer should probably support the same. Just opening this as a placeholder. I haven't looked much into what's involved yet. (Will updating the notebook components used in nbviewer fix it? Adding post_embedhtml.EmbedPostProcessor to what nbviewer is running (jupyter/nbconvert#328)?)

@scottdraves
Copy link
Contributor

any plans to address this?

@carlthome
Copy link

ETA?

@rmadar
Copy link

rmadar commented Feb 15, 2018

I also think this feature would be very good to have, in order to fully exploit notebook exportation into different formats (typically useful for slides).

@scottdraves
Copy link
Contributor

We would like to develop a fix for this. Any special guidance from the maintainers?

@rmadar
Copy link

rmadar commented Mar 1, 2018

I am neither a developer nor a maintainer but I had started to look at the code and I think it might come from line 40 of nbconvert/preprocessors/convertfigures.py where only outputs cells are looked at (while copy-pasted figures are stored as attachments). Maybe that can help ...

image

@parente parente added type:Enhancement A proposed extension to the behavior of the project tag:Upstream Related to an upstream project (e.g., mistune, nbconvert) or notebook example labels Jul 10, 2018
@turkialjrees
Copy link

Inspecting the HTML file, it's easy to spot the problematic piece of code, as what in the notebook was
test
becomes
<img src="./graphics/githubSF.png" alt="test" width=600>.
To give a bit more context with images, the notebook cell

foghegehog added a commit to foghegehog/mlcourse.ai that referenced this issue Mar 8, 2019
…d of attachments as they seem to be not supported in nbviewer yet: jupyter/nbviewer#692
Yorko pushed a commit to Yorko/mlcourse.ai that referenced this issue Apr 27, 2019
…d of attachments as they seem to be not supported in nbviewer yet: jupyter/nbviewer#692
Yorko pushed a commit to Yorko/mlcourse.ai that referenced this issue Apr 27, 2019
…d of attachments as they seem to be not supported in nbviewer yet: jupyter/nbviewer#692
Yorko pushed a commit to Yorko/mlcourse.ai that referenced this issue May 12, 2019
…d of attachments as they seem to be not supported in nbviewer yet: jupyter/nbviewer#692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:Upstream Related to an upstream project (e.g., mistune, nbconvert) or notebook example type:Enhancement A proposed extension to the behavior of the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants