Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Release Scripts #1874

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Update Release Scripts #1874

merged 2 commits into from
Mar 28, 2024

Conversation

blink1073
Copy link
Contributor

Copy link
Contributor

Binder 👈 Launch a Binder on branch jupyter/nbgrader/update-release-scripts

@blink1073
Copy link
Contributor Author

@brichet can you please add blink1073 to the PyPI project so I can set up trusted publishing?

@blink1073
Copy link
Contributor Author

Also, you'll need to create an npm token and replace the NPM_TOKEN secret.

@brichet
Copy link
Contributor

brichet commented Mar 28, 2024

Thanks @blink1073 for quick update.

Look like I can't add you on PyPI

Maybe @jtpio or @SylvainCorlay can ? And if you can please also add me as owner, it would be great.

@brichet
Copy link
Contributor

brichet commented Mar 28, 2024

Also, you'll need to create an npm token and replace the NPM_TOKEN secret.

Not sure to understand that one, the current NPM_TOKEN secret is still valid.
Do I have to change something when creating it again ?

@jtpio
Copy link
Member

jtpio commented Mar 28, 2024

Maybe @jtpio or @SylvainCorlay can ? And if you can please also add me as owner, it would be great.

I don't have manage access:

image

@blink1073
Copy link
Contributor Author

Not sure to understand that one, the current NPM_TOKEN secret is still valid.

There wasn't one set, I just set it to the one for the @jupyter org, but this package isn't in that namespace. I don't have access to the npm package.

@brichet
Copy link
Contributor

brichet commented Mar 28, 2024

Not sure to understand that one, the current NPM_TOKEN secret is still valid.

There wasn't one set, I just set it to the one for the @jupyter org, but this package isn't in that namespace. I don't have access to the npm package.

Strange, I used the releaser to push on NPM 2 days ago, using a token that I created
Screenshot from 2024-03-28 15-55-44

No matter, I updated the value of the NPM_TOKEN.

Perhaps we should move the package to the @jupyter namespace later. We could then use the token from the @jupyter org, no ?

@blink1073
Copy link
Contributor Author

Perhaps we should move the package to the @jupyter namespace later. We could then use the token from the @jupyter org, no ?

Yes, all you'd have to do is rename it in package.json and ping me to update the token.

@blink1073
Copy link
Contributor Author

Trusted publishing is set up, ready to go!

@brichet brichet merged commit 8011099 into main Mar 28, 2024
24 checks passed
@brichet
Copy link
Contributor

brichet commented Mar 28, 2024

Thanks a lot @blink1073

@blink1073
Copy link
Contributor Author

No problem!

@blink1073 blink1073 deleted the update-release-scripts branch March 28, 2024 18:53
@brichet
Copy link
Contributor

brichet commented Mar 28, 2024

Perhaps we should move the package to the @jupyter namespace later. We could then use the token from the @jupyter org, no ?

Yes, all you'd have to do is rename it in package.json and ping me to update the token.

Do you know if it will be possible to bring the history back to the new package ?

@blink1073
Copy link
Contributor Author

Do you know if it will be possible to bring the history back to the new package ?

I don't know, I haven't dealt with npm packages directly in a few years.

AlirezaT99 pushed a commit to AaltoSciComp/nbgrader that referenced this pull request Aug 6, 2024
* Update Release Scripts

* add npm token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants