Ensure collapsed mergepane border #731
Conversation
After switching to grid based layout, each pane had its own border. With 0px gap, the border still did not collapse to single 1px border, so instead we switch to using gap + background-color. C.f. https://stackoverflow.com/questions/47882924/preventing-double-borders-in-css-grid
vidartf
requested review from
HaudinFlorence and
krassowski
and removed request for
HaudinFlorence
|
Bot please update playwright snapshots |
|
Playwright windows-latest snapshots updated. |
|
Playwright ubuntu-22.04 snapshots updated. |
|
Bot please update playwright snapshots |
|
Playwright windows-latest snapshots updated. |
|
Playwright ubuntu-22.04 snapshots updated. |
There was a problem hiding this comment.
It feels like the old version (a single green border) looked cleaner than the new one (a green border in grey outline).
There was a problem hiding this comment.
I think you are right, probably the rule shouldn't be added for the 1-way.
Now borders are more similar to that of previous version, except double borders are avoided if possible.
|
Bot please update playwright snapshots |
|
Attempted tweak in++, and now also fixes #732. |
|
Playwright windows-latest snapshots updated. |
|
Playwright ubuntu-22.04 snapshots updated. |
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Including fixing a broken style that used a private variable.
Thanks for pointing it out. Rerending via the bot was the last thing I did on Wednesday EOD. I rely on it since #729 prevents UI test from being useful locally for me. |
|
Bot please update playwright snapshots |
|
Playwright windows-latest snapshots updated. |
|
Playwright ubuntu-22.04 snapshots updated. |
Followup to #728 After switching to grid based layout, each pane had its own border. With 0px gap, the border still did not collapse to single 1px border, so instead we switch to using gap + background-color.
C.f. https://stackoverflow.com/questions/47882924/preventing-double-borders-in-css-grid
Fixes #732.