Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pickers for empty chunks #691

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Fix pickers for empty chunks #691

merged 4 commits into from
Sep 28, 2023

Commits on Sep 21, 2023

  1. Fix wrong picker marker (a typo during lab 4.0 migration)

    @krassowski
    krassowski committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    0a7954e View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. Restore pickers on empty chunks 

    Empty chunks are represented using `PaddingWidget` which is a block
widget; block widgets do not have a corresponding line, therefore one
cannot place a gutter marker over them using `markers` method; instead
a dedicated `widgetMarker` method needs to be defined.
    @krassowski
    krassowski committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    2a96d26 View commit details
    Browse the repository at this point in the history

  2. Update Playwright Snapshots

    @github-actions
    github-actions[bot] committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    6bbe868 View commit details
    Browse the repository at this point in the history

  3. Update Playwright Snapshots

    @github-actions
    github-actions[bot] committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    682333d View commit details
    Browse the repository at this point in the history