Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong picker marker (a typo during lab 4.0 migration) #688

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

krassowski
Copy link
Member

This is a follow-up to #673, something I noticed when looking into #676

For reference, this is the corresponding code on 3.2 branch:

// When the chunk is empty, make sure a horizontal line shows up
if (from === to) {
let line = editor.addLineClass(from, 'background', classes.start);
if (self.type !== 'merge') {
let picker = elt('div', PICKER_SYMBOL, classes.gutter);
(picker as any).sources = sources;
picker.classList.add(GUTTER_PICKER_CLASS);
editor.setGutterMarker(line, GUTTER_PICKER_CLASS, picker);
} else if (conflict) {
// Add conflict markers on editor, if conflicted
let conflictMarker = elt('div', CONFLICT_MARKER, '');
(conflictMarker as any).sources = sources;
conflictMarker.classList.add(GUTTER_CONFLICT_CLASS);
editor.setGutterMarker(line, GUTTER_CONFLICT_CLASS, conflictMarker);
}
editor.addLineClass(line, 'background', classes.end + '-empty');
markers.push(line);
}

it was also using conflict so I assume picker here on the master branch is a typo.

Copy link
Contributor

@HaudinFlorence HaudinFlorence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krassowski Thanks for pointing this wrong picker marker. This seems to be an error or a copy paste reminiscence.

@vidartf vidartf merged commit 2db03bc into jupyter:master Sep 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants