Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JupyterLab 4.0, port to Lumino 2 #673

Merged
merged 21 commits into from
Sep 18, 2023

Commits on Sep 9, 2023

  1. Configuration menu
    Copy the full SHA
    43b0608 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    79414bb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6f65fd4 View commit details
    Browse the repository at this point in the history
  4. Update dependencies.

    HaudinFlorence committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    1f80d1d View commit details
    Browse the repository at this point in the history
  5. Fixed build

    JohanMabille authored and HaudinFlorence committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    9cce097 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f6d431b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    78cd4fd View commit details
    Browse the repository at this point in the history
  8. Keep on migrating padding (one effect by editor using decoration sets…

    …), add a listener, try to reintroduce syntax highlighting (not yet working) and introduce minor css changes.
    HaudinFlorence committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    d461c0f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6d97463 View commit details
    Browse the repository at this point in the history
  10. Keep on migrating gutter markers

    Update onGutterClick method, syncModel
    Update of the mergeView
    Perform some renaming
    Add methods to remove the line-chunk mapping and the gutter markers
    Refactoring of the code : remove most of create effect methods except for the gutter effects.
    HaudinFlorence committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    8156966 View commit details
    Browse the repository at this point in the history
  11. Restore the missing syntax highlighting

    Choose the extensions to be added from Jupyterlab default ones
    Migrate the synchronized scrolling
    Add transparent borders to the chunk decorations
    Update mergeview.ts and relative styling to make nbdiff work
    HaudinFlorence committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    7bd87c9 View commit details
    Browse the repository at this point in the history
  12. Update alignViews in mergeview.ts to correct padding issues (only the…

    … diff is implemented)
    
    Update css files
    HaudinFlorence committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    660f8ef View commit details
    Browse the repository at this point in the history
  13. Fix spacers algorithm

    fcollonval authored and HaudinFlorence committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    ec92d93 View commit details
    Browse the repository at this point in the history
  14. Fix last spacer

    fcollonval authored and HaudinFlorence committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    414eb76 View commit details
    Browse the repository at this point in the history
  15. Add first ui-tests

    Update mergeview.ts and editor.ts with minor changes
    Update example9 files.
    
    Update mergeview.ts to take review comments into account.
    
    Update css files with minor changes.
    
    Update to take review into account.
    
    Keep on taking review into account regarding the iterator issue, dependencies and CI troubles.
    
    Add jest types
    
    Try fix CI js failing tests and try to fix PatchObjectHelper iterator.
    Remove any reference to jupyter_server_mathjax and related references.
    
    Fix iterator implementation on `PatchObjectHelper`
    
    Fix tests
    
    Fix Python test failing due to retained decorator
    
    Remove one more remnant of old mathjax
    
    Disable auto-detection of language servers to reduce startup time
    
    Add ui-tests to github workflows.
    
    Add missing directory with example notebooks data/default/test2.
    
    Try to make ui-tests work.
    
    Update ./github/workflows/tests.yml
    
    Update .github/workflows/tests.yml
    
    Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
    
    Remove last commit change adding option --update-snapshots for npx playwright test and add update-integration-tests.yml for to .github/workflows.
    
    Update .github/workflows/tests.yml
    
    Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
    
    Update .github/workflows/update-integration-tests.yml
    
    Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
    
    Take comments into account regarding test.yml file and tests.
    
    Apply suggestions from code review
    
    Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
    
    Remove `set -eux` because it is Unix-only
    
    Use npm client
    
    Actually pass python version to setup script
    
    Add missing `run`
    
    Add comment/reaction steps
    
    Add polyfill for playwright npx run
    
    Only update snapshots on latest Python, run one at a time
    
    to avoid git conflicts
    
    Update Playwright Snapshots
    
    Apply suggestions from code review
    
    Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
    
    Restore green colors backgrounds for the right editor for a diff.
    
    Fix the added cells CSS style.
    
    Fix alignment shift for diff in alignViews.
    
    Fix `lineChunks` and editor configuration, including readOnly
    
    Remove hard-coded `lineNumbers` option
    
    Update mergeview.ts and diff.css to try to fix the added or deleted cells backgrounds.
    
    Take comment into account to fix the background of added/deleted cells.
    
    Restore `getMergedValue()`
    
    Restore border indicator, remove unused .CodeMirror selector
    
    Add ui-tests for diff and change ui-tests names and descriptions.
    
    Fix dep specification
    
    Restore CSS scoping
    
    Reduce diff due to format changes
    
    Restore `getMergedValue`
    
    Improve integration tests
    
    Improve integration tests
    
    Avoid duplicating example/test contents
    
    Instantiate registries only once
    
    Only create editor factory (and associated registries) once
    
    Don't remove favicon when cleaning
    
    Remove old typings
    
    Fix style not deduplicated
    
    Use only prebuilt extension
    
    Fix jobs config
    
    Fix jest tests
    
    Fix integration tests
    
    Fix wheel name for windows
    
    Pass wheel name to ui-test job
    
    Update symlink
    
    Update Playwright Snapshots
    
    Update Playwright Snapshots
    
    Update ui-tests/tests/nbdime-merge-test1.spec.ts
    HaudinFlorence committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    6005c0d View commit details
    Browse the repository at this point in the history
  16. Fix following rebase.

    HaudinFlorence committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    711fa95 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Configuration menu
    Copy the full SHA
    ecc4478 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Update packages/labextension/src/actions.ts

    Co-authored-by: Vidar Tonaas Fauske <vidartf@gmail.com>
    HaudinFlorence and vidartf authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    c721222 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    63c9c24 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f3e4821 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Remove broken examples

    vidartf committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    872a71c View commit details
    Browse the repository at this point in the history