-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace mock with unittest.mock #651
Conversation
The latter is available with Python 3.3 [1], and nbdime requires Python 3.6+ as per setup.py. This change removes the need of an external library. [1] https://docs.python.org/3/library/unittest.mock.html
This pull request is a preparation for adding python-nbdime package to Arch Linux, where it's encouraged to replace mock with unittest.mock: https://archlinux.org/todo/drop-python-mock-checkdepends/ |
* `--openssl-legacy-provider`: webpack reports an error with OpenSSL 3 [1] as webpack uses md4, which is available only from the legacy provider. Newer webpack adds a wasm implementation of md4 [2], while nbdime uses very old webpack [3]. * Node.js 14.x: some dependencies (ex: @jupyter/ydoc) uses ES modules, which are declared as stable since Node.js 14.x [4] [1] webpack/webpack#14532 [2] webpack/webpack#14584 [3] https://github.com/jupyter/nbdime/blob/2da614b603b694e13fc8d597eef1cc09ff07cb10/packages/webapp/package.json#L44 [4] https://nodejs.org/docs/latest-v14.x/api/esm.html
@vidartf I changed some CI settings to fix current errors. Could you re-run failed tests? Also, please tell me if you prefer to split CI changes to a separate pull request. |
Thanks for this, and the detailed descriptions in the commit message. If I read this correctly: if we update webpack, we can drop the openssl flag? |
yep |
Merging for now, will look at updating webpack later. Thanks! :) |
Ref: jupyter/nbdime#651 git-svn-id: file:///srv/repos/svn-community/svn@1431363 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Ref: jupyter/nbdime#651 git-svn-id: file:///srv/repos/svn-community/svn@1431363 9fca08f4-af9d-4005-b8df-a31f2cc04f65
The latter is available with Python 3.3 [1], and nbdime requires Python 3.6+ as per setup.py.
This change removes the need of an external library.
[1] https://docs.python.org/3/library/unittest.mock.html