Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript #641

Merged
merged 15 commits into from
Jan 15, 2023
Merged

Update typescript #641

merged 15 commits into from
Jan 15, 2023

Conversation

gwincr11
Copy link
Contributor

I am working on another pr which uses newer typescript features, so I thought I would update it first. This pr updates to typescript 4.9 and fixes the resulting errors. It also sets up a stricter tsconfig_base which is used by all tsconfig files and fixes the resulting errors.

I am working on another pr which uses newer typescript features, so I thought I would update it first.
This pr updates to typescript 4.9 and fixes the resulting errors. It also
sets up a stricter tsconfig_base which is used by all tsconfig files and
fixes the resulting errors.
vidartf and others added 12 commits January 14, 2023 16:07
Reverts parameter renames, and removes tsconfig settings with the default values. Removes as error expected directives, and fixes typings in another way.
This forces type-only imports to be imported with `import type`
With jupyter_server 2.0, we cannot support launching with notebook. The tests can potentially be reenabled with notebook 7.0, as it is based on jupyter_server.
When there is a token, xsrf cookies/headers are ignored, so using it makes tests easier.
@vidartf vidartf merged commit a02615e into jupyter:master Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants