Optimize text comparison for text MIME data #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Difflib's ratio() method blows up for very large contents. We limit this problem for output comparison by giving a maximum length for text data when doing mimedata comparison.
|
TODO:
|
Uses random data to ensure large edit strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #237.
Difflib's ratio() method blows up for very large contents. This PR limits this problem for output comparison by giving a maximum length for text data when doing mimedata comparison. If both sides of the comparison are larger than this length, it will revert to strict equality instead of the slow
ratio()method.