Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use diff args for git diff driver #281

Merged
merged 5 commits into from
Apr 18, 2017
Merged

Conversation

vidartf
Copy link
Collaborator

@vidartf vidartf commented Apr 13, 2017

No description provided.

They do three request cycles, so triple the timeout.
Tests where the diff targets are set need to reset the state on
teardown. Previously, only parts of the tests did this correctly. Now
adds a fixture for it, and uses that where necessary.
@vidartf
Copy link
Collaborator Author

vidartf commented Apr 18, 2017

All green with tests :)

@minrk minrk merged commit c8f5544 into jupyter:master Apr 18, 2017
@vidartf vidartf deleted the add-diff-driver-args branch April 19, 2017 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants