-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes and minor adjustments #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I made one comment about a simpler way to make case-insensitive regexps.
nbdime/diffing/notebooks.py
Outdated
|
||
re_pointer = re.compile(r"0[xX][a-zA-Z0-9]{8,16}") | ||
re_pointer = re.compile(r"0[xX][a-fA-F0-9]{8,16}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These can be simplified by adding , re.IGNORECASE)
instead of explicit casing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
This extracts the bug-fixes and simple improvements from #237 for eased review. Should also simplify the diff of #237.