Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty print color contrasts #240

Open
vidartf opened this issue Jan 16, 2017 · 0 comments
Open

Pretty print color contrasts #240

vidartf opened this issue Jan 16, 2017 · 0 comments

Comments

@vidartf
Copy link
Collaborator

vidartf commented Jan 16, 2017

In the pretty printed output, the headers are printed in blue. In terminals with black backgrounds, this leads to very poor contrast (blue on black). The green/red/yellow outputs are all OK (at least to my eyes). We should consider if there is another color that would fit better, but that would also work for terminals with light background.

tallamjr added a commit to tallamjr/nbdime that referenced this issue Feb 4, 2022
Ass addressed in jupyter#240 the
headers are printed in BLUE, which is hard to read when using git
integration in a dark terminal.

This allows for the color to remain the same, but just to brighten it up
such that is more readable.

Refs:
    - https://github.com/tartley/colorama/blob/34703ece90fc4996727adff31502bad8a8e88066/demos/demo03.py#L15

	modified:   prettyprint.py
tallamjr added a commit to tallamjr/nbdime that referenced this issue Feb 4, 2022
As addressed in jupyter#240 the
headers are printed in BLUE, which is hard to read when using git
integration in a dark terminal.

This allows for the color to remain the same, but just to brighten it up
such that is more readable.

Refs:
    - https://github.com/tartley/colorama/blob/34703ece90fc4996727adff31502bad8a8e88066/demos/demo03.py#L15

	modified:   prettyprint.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant