Skip to content

Commit

Permalink
Add delay to improve test robustness on Windows
Browse files Browse the repository at this point in the history
  • Loading branch information
@fcollonval
fcollonval committed Oct 10, 2023
1 parent 301c10d commit d93460a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ui-tests/tests/nbdime-merge-test3.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ test.beforeEach(async ({ page }) => {
/* 2 cells with merge conflict */
test.describe('merge test3', () => {
test('should warn for remaining conflicts', async ({ page }) => {
await page.waitForTimeout(300);
await expect.soft(page.getByText('➭')).toHaveCount(25);

Check failure on line 15 in ui-tests/tests/nbdime-merge-test3.spec.ts

View workflow job for this annotation

GitHub Actions / ui-test (ubuntu-22.04)

tests/nbdime-merge-test3.spec.ts:13:7 › merge test3 › should warn for remaining conflicts 

  1) tests/nbdime-merge-test3.spec.ts:13:7 › merge test3 › should warn for remaining conflicts ─────
    Error: Timed out 5000ms waiting for expect(received).toHaveCount(expected) // deep equality

    Expected: 25
    Received: 26
    Call log:
      - expect.soft.toHaveCount with timeout 5000ms
      - waiting for getByText('➭')
      -   locator resolved to 26 elements
      -   unexpected value "26"
      -   locator resolved to 26 elements
      -   unexpected value "26"
      -   locator resolved to 26 elements
      -   unexpected value "26"
      -   locator resolved to 26 elements
      -   unexpected value "26"
      -   locator resolved to 26 elements
      -   unexpected value "26"
      -   locator resolved to 26 elements
      -   unexpected value "26"
      -   locator resolved to 26 elements
      -   unexpected value "26"
      -   locator resolved to 26 elements
      -   unexpected value "26"


      13 |   test('should warn for remaining conflicts', async ({ page }) => {
      14 |     await page.waitForTimeout(300);
    > 15 |     await expect.soft(page.getByText('➭')).toHaveCount(25);
         |                                            ^
      16 |
      17 |     await page.getByRole('button', { name: 'Download' }).click();
      18 |

        at /home/runner/work/nbdime/nbdime/ui-tests/tests/nbdime-merge-test3.spec.ts:15:44

Check failure on line 15 in ui-tests/tests/nbdime-merge-test3.spec.ts

View workflow job for this annotation

GitHub Actions / ui-test (ubuntu-22.04)

tests/nbdime-merge-test3.spec.ts:13:7 › merge test3 › should warn for remaining conflicts 

  1) tests/nbdime-merge-test3.spec.ts:13:7 › merge test3 › should warn for remaining conflicts ─────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: Timed out 5000ms waiting for expect(received).toHaveCount(expected) // deep equality

    Expected: 25
    Received: 26
    Call log:
      - expect.soft.toHaveCount with timeout 5000ms
      - waiting for getByText('➭')
      -   locator resolved to 26 elements
      -   unexpected value "26"
      -   locator resolved to 26 elements
      -   unexpected value "26"
      -   locator resolved to 26 elements
      -   unexpected value "26"
      -   locator resolved to 26 elements
      -   unexpected value "26"
      -   locator resolved to 26 elements
      -   unexpected value "26"
      -   locator resolved to 26 elements
      -   unexpected value "26"
      -   locator resolved to 26 elements
      -   unexpected value "26"
      -   locator resolved to 26 elements
      -   unexpected value "26"


      13 |   test('should warn for remaining conflicts', async ({ page }) => {
      14 |     await page.waitForTimeout(300);
    > 15 |     await expect.soft(page.getByText('➭')).toHaveCount(25);
         |                                            ^
      16 |
      17 |     await page.getByRole('button', { name: 'Download' }).click();
      18 |

        at /home/runner/work/nbdime/nbdime/ui-tests/tests/nbdime-merge-test3.spec.ts:15:44

await page.getByRole('button', { name: 'Download' }).click();
Expand Down

0 comments on commit d93460a

Please sign in to comment.