Skip to content

Commit

Permalink
Add comments about changes or configurations.
Browse files Browse the repository at this point in the history
  • Loading branch information
HaudinFlorence committed Sep 11, 2023
1 parent 711fa95 commit cdcd7a4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion nbdime/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,7 @@ def _kill_nb_app():
'--port=%i' % port,
'--ip=127.0.0.1',
'--log-level=DEBUG',
'--LanguageServerManager.autodetect=False',
'--LanguageServerManager.autodetect=False', #' adding this fixed the last failing Python test, that was working locally and simply timing out on CI because search for language servers was taking long time on slow CI file system.
'--no-browser', '--%s.token=%s' % (token_config_location, TEST_TOKEN)],
env=env)

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"devDependencies": {
"@jupyterlab/buildutils": "4.0.0",
"@jupyterlab/testutils": "4.0.0",
"@types/jest": "^29.5.4",
"@types/jest": "^29.5.4", /* added in the migration to jupyterlab4*/
"@types/mocha": "^10.0.1",
"@types/node": "^20.5.7",
"jest": "^29.6.4",
Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@
'GitPython!=2.1.4, !=2.1.5, !=2.1.6', # For difftool taking git refs
'jupyter_server',
'jinja2>=2.9',
# Note that references to jupyter_server_mathjax have been removed since MathJax4 implementation in JupyterLab 4 now ships all static assets by itself, so there is no need for it. Indeed The import in the server, from jupyter_server_mathjax.app import STATIC_ASSETS_PATH.
]

extras_require = setup_args['extras_require'] = {
Expand Down

0 comments on commit cdcd7a4

Please sign in to comment.