Removed python 3.4 support, added 3.7 to tests #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
huzzah LGTM! |
|
@Carreau I wanted to hear from you before I merged. But my finger is hovering over the button :D. |
mpacer
approved these changes
Apr 4, 2019
|
Sounds good ! |
Carreau
approved these changes
Apr 4, 2019
|
Sounds good. If we are moving support for 3.4 do you want to bump the major version number ? I don't see any needs to do that, but it can also be a good time to maybe drop some 3.4 compatibility APIs if we have some. |
|
I was planning on doing a 5.5 release in a week or two -- there's a lot of good work built up. Would you rather it jump to 6.0? Also totally down to go scrub 3.4 specific branches of code if you know where any are. |
|
There does not seem to be any 3.4 specific code, so I guess a 5.5 is fine. Thanks for handling all of that ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in person with @mpacer -- given our several underlying libraries no longer support 3.4 and we see some consistent test failures on PRs with 3.4 we thought removing python 3.4 from nbconvert 5.5 would make sense.