Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDFExporter currently has its "output_mimetype" traitlet to be 'text/latex' #972

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

Madhu94
Copy link
Contributor

@Madhu94 Madhu94 commented Mar 25, 2019

Closes #970

This causes issues when using "Export to pdf" option in the notebook,
as the notebook web application uses this traitlet's value as the
mimetype of the attached file.

'text/latex', from its superclass.

This causes issues when using "Export to pdf" option in the notebook,
as the notebook web application uses this traitlet's value as the
mimetype of the attached file.
@MSeal
Copy link
Contributor

MSeal commented Mar 26, 2019

LGTM, thanks for making the fix.

@MSeal MSeal merged commit 914be01 into jupyter:master Mar 26, 2019
@MSeal MSeal added this to the 5.5 milestone Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDFExporter needs to have output_mimetype attribute set
2 participants