Convert proxy handler from callback to coroutine #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the tornado docs, the web.asynchronous decorator is deprecated in 5.1 and will be removed in 6.0. There's no direct suggested replacement; it just says to use coroutines instead.
MSeal
approved these changes
Jan 18, 2019
|
Looks good. That reminds me that we need to get the patch release going as well. |
|
@takluyver hey Thomas, I'm still getting the 500 Internal Server Error on the jupyter notebook. Any idea of what I should do? |
|
If you're seeing the error this PR fixed, it's because you're using tornado 6.0a1 - a as in alpha. In that case, what you should do is go back to the stable version: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the tornado docs, the
web.asynchronousdecorator is deprecated in 5.1 and will be removed in 6.0. There's no direct suggested replacement; it just says to use coroutines instead.