Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use utf-8 encoding in execute_api example #921

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Conversation

JarnoRFB
Copy link
Contributor

As not setting the utf-8 encoding explicitly might produce broken notebooks on Windows, the encoding is set explicitly in the example. Moreover, the mode is set to 'w' only as text mode is standard for open and the 't' flag is not commonly used.

As not setting the utf-8 encoding explicitly might produce broken notebooks on Windows, the encoding is set explicitly in the example. Moreover, the mode is set to 'w' only as text mode is standard for open and the 't' flag is not commonly used.
@takluyver takluyver added this to the 5.5 milestone Jan 31, 2019
@takluyver takluyver added the docs label Jan 31, 2019
@takluyver
Copy link
Member

Closing/reopening to rerun tests with updated merge.

@takluyver takluyver closed this Jan 31, 2019
@takluyver takluyver reopened this Jan 31, 2019
@takluyver takluyver merged commit 3ae582e into jupyter:master Jan 31, 2019
@takluyver
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants