Add export_from_notebook #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was working on jupyter/notebook#3879 and it looks like the intended way to determine whether the exporter should show up in the list generated by the notebook server was by checking `export_from_notebook`, but it isn't defined for any of the builtin exporters. The docs also say this specifies a friendly name for the exporter. In the PR mentioned above, I used the name defined by the entrypoint to key the exporter. It sounds like maybe we should use the value in `export_from_notebook` instead, so I've made them match, but perhaps it's confusing to have a "name" for the entrypoint in two places.
This was referenced Aug 25, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on jupyter/notebook#3879 and it
looks like the intended way to determine whether the exporter should
show up in the list generated by the notebook server was by checking
export_from_notebook, but it isn't defined for any of the builtinexporters.
The docs also say this specifies a friendly name for the exporter. In
the PR mentioned above, I used the name defined by the entrypoint to key
the exporter. It sounds like maybe we should use the value in
export_from_notebookinstead, so I've made them match, but perhapsit's confusing to have a "name" for the entrypoint in two places.